-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default nucleotide and amino acid sequence #510
default nucleotide and amino acid sequence #510
Conversation
This is a preview of the changelog of the next release: 0.2.9 (2024-07-18)Features
Bug Fixes |
1666205
to
f92a472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quick! A few minor comments
@@ -126,6 +128,42 @@ Database Preprocessor::preprocess() { | |||
); | |||
} | |||
|
|||
void Preprocessor::checkConfig() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this function name a little confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the name or because of the content? I'm also not super happy with the name. Suggestions are welcome ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name made me think that it would not mutate the config
Maybe finalize / resolve?
Otherwise an extra class ValidatedDatabaseConfig which also takes the ReferenceGenomes in its constructor would be viable
or we can leave it as a TODO for #426 , where we want to specify the unaligned sequences (and I would also say the aligned nuc and aa sequences) in the database config to reduce this dependency. Then the reference genomes is no longer a config for the sequences in the database but only a map for looking up the references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok good point. check
doesn't imply mutating. I renamed it to finalizeConfig
.
ValidatedDatabaseConfig
is only partially true, because you also need to validate it against the data (e.g. that all metadata fields are present etc.). So I'm not sure whether that would be a good name either.
If we want to redesign this anyway, then I'd propose to leave the rest to #426.
05a167e
to
245bea9
Compare
245bea9
to
f15a7fb
Compare
resolves #454
Summary
Changes in this PR:
sequenceName
field, if the config has the default sequences.PR Checklist
[ ] All necessary documentation has been adapted or there is an issue to do so.-> Docs: default sequences in database config LAPIS#862