Process chunks column-wise in the table reader #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taepper
reviewed
Jun 17, 2024
|
And also rebase onto current main for a better change list :) |
Taepper
force-pushed
the
column-wise-lambda
branch
from
143dc81 to
dda828f
Compare
|
What's the new feature in this PR? Or should the commit message say |
I will change it to |
Taepper
force-pushed
the
column-wise-lambda
branch
3 times, most recently
from
96c491a to
f2f61e3
Compare
Taepper
force-pushed
the
column-wise-lambda
branch
from
f2f61e3 to
9381f3d
Compare
Taepper
approved these changes
Jun 20, 2024
fengelniederhammer
added a commit
that referenced
this pull request
Jun 25, 2024
The bug was introduced in #483 and only occured when the table reader tried to read the second chunk. Thus: also add a preprocessor test with a dataset that is large enough so that the bug occurs.
1 task
fengelniederhammer
added a commit
that referenced
this pull request
Jun 25, 2024
The bug was introduced in #483 and only occured when the table reader tried to read the second chunk. Thus: also add a preprocessor test with a dataset that is large enough so that the bug occurs.
davidgicev
added a commit
that referenced
this pull request
Aug 4, 2024
Co-authored-by: David Gichev <[email protected]>
davidgicev
pushed a commit
that referenced
this pull request
Aug 4, 2024
The bug was introduced in #483 and only occured when the table reader tried to read the second chunk. Thus: also add a preprocessor test with a dataset that is large enough so that the bug occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #291
Summary
We now use tbb::parallel_for to build the different columns in parallel per input chunk.
PR Checklist
- [ ] All necessary documentation has been adapted or there is an issue to do so.- [ ] The implemented feature is covered by an appropriate test.