Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename "position" in aa_mutations and nuc_mutations to "mutation" #201

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

JonasKellerer
Copy link
Contributor

  • to be compatible with lapisv1, which also returns mutation,count,proportion
  • name represents the value better, since it has also symbols inside. Positions are only numbers.

This change is necessary for: GenSpectrum/LAPIS#206

Copy link
Collaborator

@Taepper Taepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been with base aa-insertions. Anyways, now wait for #200

- to be compatibile with lapisv1
- name represents the value better, since it has also symbols inside. Positions are only numbers.
@Taepper Taepper force-pushed the renamePositionToMutation branch from 246f89d to cffdba2 Compare August 30, 2023 18:14
@Taepper Taepper merged commit 7305854 into main Aug 30, 2023
@Taepper Taepper deleted the renamePositionToMutation branch August 30, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants