fix: insertion column, remove reference

GenSpectrum · Aug 30, 2023 · d940c52 · d940c52
1 parent cef4d48
commit d940c52
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/silo/storage/column/insertion_column.h b/include/silo/storage/column/insertion_column.h
@@ -40,11 +40,11 @@ class InsertionColumnPartition {
    common::BidirectionalMap<std::string>& lookup;
 
   public:
-   const std::optional<std::string>& default_sequence_name;
+   const std::optional<std::string> default_sequence_name;
 
    explicit InsertionColumnPartition(
       common::BidirectionalMap<std::string>& lookup,
-      const std::optional<std::string>& default_sequence_name
+      const std::optional<std::string> default_sequence_name
    );
 
    void insert(const std::string& value);

diff --git a/src/silo/storage/column/insertion_column.cpp b/src/silo/storage/column/insertion_column.cpp
@@ -48,11 +48,11 @@ InsertionEntry parseInsertion(
 template <typename SymbolType>
 InsertionColumnPartition<SymbolType>::InsertionColumnPartition(
    common::BidirectionalMap<std::string>& lookup,
-   const std::optional<std::string>& default_sequence_name
+   const std::optional<std::string> default_sequence_name
 
 )
     : lookup(lookup),
-      default_sequence_name(default_sequence_name) {}
+      default_sequence_name(std::move(default_sequence_name)) {}
 
 template <typename SymbolType>
 void InsertionColumnPartition<SymbolType>::insert(const std::string& value) {