fix: error when the Mutations action looked for sequences but the fil…

…ter was empty
GenSpectrum · Sep 8, 2023 · 91e5d52 · 91e5d52
1 parent 2590b66
commit 91e5d52
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 3 deletions.
diff --git a/endToEndTests/test/queries/insertionContains_noSeqCol.json b/endToEndTests/test/queries/insertionContains_noSeqCol.json
@@ -0,0 +1,29 @@
+{
+  "testCaseName": "Insertion Contains without sequence or column specified",
+  "query": {
+    "action": {
+      "type": "Mutations",
+      "minProportion": 1
+    },
+    "filterExpression": {
+      "type": "And",
+      "children": [
+        {
+          "type": "InsertionContains",
+          "position": 25701,
+          "value": "CC.*"
+        },
+        {
+          "type": "InsertionContains",
+          "position": 22339,
+          "value": ".*C.*G.*"
+        }
+      ]
+    }
+  },
+  "expectedQueryResult": [
+    {
+      "count": 1
+    }
+  ]
+}
diff --git a/endToEndTests/test/queries/mutations_False.json b/endToEndTests/test/queries/mutations_False.json
@@ -0,0 +1,17 @@
+{
+  "testCaseName": "Mutations action without sequence and empty result",
+  "query": {
+    "action": {
+      "type": "Mutations",
+      "minProportion": 1
+    },
+    "filterExpression": {
+      "type": "False"
+    }
+  },
+  "expectedQueryResult": [
+    {
+      "count": 1
+    }
+  ]
+}
diff --git a/src/silo/query_engine/actions/mutations.cpp b/src/silo/query_engine/actions/mutations.cpp
@@ -216,9 +216,14 @@ QueryResult Mutations<SymbolType>::execute(
       const SequenceStore<SymbolType>& sequence_store =
          database.getSequenceStores<SymbolType>().at(sequence_name);
 
-      addMutationsToOutput(
-         sequence_name, sequence_store, bitmaps_to_evaluate.at(sequence_name), mutation_proportions
-      );
+      if (bitmaps_to_evaluate.contains(sequence_name)) {
+         addMutationsToOutput(
+            sequence_name,
+            sequence_store,
+            bitmaps_to_evaluate.at(sequence_name),
+            mutation_proportions
+         );
+      }
    }
    return {mutation_proportions};
 }