fix: fix recall_app with default app_name

GehaFearless · Mar 11, 2024 · 36b2789 · 36b2789
1 parent 2bcdaf5
commit 36b2789
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/client/replication_ddl_client.cpp b/src/client/replication_ddl_client.cpp
@@ -226,8 +226,11 @@ dsn::error_code replication_ddl_client::drop_app(const std::string &app_name, in
 
 dsn::error_code replication_ddl_client::recall_app(int32_t app_id, const std::string &new_app_name)
 {
-    RETURN_EC_NOT_OK_MSG(
-        validate_app_name(new_app_name), "invalid new_app_name: '{}'", new_app_name);
+    if (!std::all_of(new_app_name.cbegin(),
+                     new_app_name.cend(),
+                     (bool (*)(int))replication_ddl_client::valid_app_char)) {
+        return ERR_INVALID_PARAMETERS;
+    }
 
     auto req = std::make_shared<configuration_recall_app_request>();
     req->app_id = app_id;