Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label offset added #12

Merged
merged 1 commit into from
Feb 28, 2023
Merged

label offset added #12

merged 1 commit into from
Feb 28, 2023

Conversation

SahilSharma2710
Copy link
Collaborator

  • added deprecated comment for labelTopMargin

Screenshot 2023-02-28 at 5 58 47 PM

  • added labelOffset property in labelStyle.
    this was the output

Screenshot 2023-02-28 at 5 59 55 PM

  • if user gives labelTopMargin when rulerPosition is bottom or center then labelTopMargin is used over labelOffset(in line 444 )

Screenshot 2023-02-28 at 6 00 44 PM

-in case of rulerPosition top it works fine

hasnentai
hasnentai approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@hasnentai hasnentai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasnentai
Copy link
Contributor

Thanks for the detailed explanation and Screenshot that helped to review it quickly

@hasnentai hasnentai merged commit 8faae4c into GeekyAnts:main Feb 28, 2023
@hasnentai hasnentai mentioned this pull request Mar 3, 2023
Closed
@hasnentai hasnentai linked an issue Mar 3, 2023 that may be closed by this pull request
Add and Offset to the RulerLabels which will allow an extra room around labels of rulers #43
Closed
@hasnentai hasnentai mentioned this pull request Mar 6, 2023
Closed
@SahilSharma2710 SahilSharma2710 deleted the label_offset_correction branch March 6, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasnentai hasnentai hasnentai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add and Offset to the RulerLabels which will allow an extra room around labels of rulers
2 participants
@SahilSharma2710 @hasnentai