-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #354 analytical damper fix #437
base: update-0.3.3
Are you sure you want to change the base?
Conversation
…ersions, and move dampers into dedicated directory
…s it is handled uniquely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the changes in dissipation.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have one small comment.
@skim0119 I did not get your point? Can you clarify.
rotational_damping_constant: np.float64, | ||
time_step: np.float64, | ||
) -> DampenType: | ||
nodal_mass = self._system.mass.view() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does view needed here?
Fix #354.
Instead of the dimensionally inconsistent implementation, three variations of analytical linear dampers are now supported:
uniform_damping_constant
1 / T
. Translation and rotation uses the same exponential damping coefficientsuch that
The users are responsible for choosing the appropriate, dimensionally consistent damping constants for both modes. Example:
Test cases are updated to accommodate the changes. Dissipation module and test cases are moved to dedicated directories.