-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing: timestepper
fix pytest and cleanup integration routine
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skim0119
force-pushed
the
typing/timestepper
branch
from
May 4, 2024 03:44
b4d1a35
to
425e14a
Compare
skim0119
force-pushed
the
typing/timestepper
branch
from
May 4, 2024 21:56
82b3060
to
42bfd09
Compare
armantekinalp
requested changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have couple of questions. Please address them. Overall looks good. Thanks @skim0119
armantekinalp
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-hinting and cleanup
timestepper
routineModification on user-API
extend_stepper_interface
andintegrate
should work same as before.extend_stepper_interface
.integrate
or custom stepping as above.Minor changes
mypy
type-hinting issues1_Timoshenko_Beam.ipynb
is updated to use new time-step routine instead ofextend_stepper_interface
method.timestepper.tag
removed as we no-longer need to check type of the stepping method.autoflake8
->autoflake
: The forked repoautoflake8
is now deprecated, andautoflake
is continued to be maintained.