Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI: Add sphinx build #139

Merged
merged 4 commits into from
Jul 16, 2022
Merged

Update CI: Add sphinx build #139

merged 4 commits into from
Jul 16, 2022

Conversation

skim0119
Copy link
Collaborator

Note

  • Also fixed some minor warnings in doc-building.
  • Removed RTD theme (outdated).

@skim0119 skim0119 added documentation Improvements or additions to documentation update Update the codebase labels Jul 16, 2022
@skim0119 skim0119 added this to the Version 0.3 milestone Jul 16, 2022
@skim0119 skim0119 requested a review from bhosale2 as a code owner July 16, 2022 17:59
@skim0119 skim0119 self-assigned this Jul 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022 •
edited
Loading

Codecov Report

Merging #139 (735fe00) into update-0.3.0 (af1b7b7) will decrease coverage by 0.10%.
The diff coverage is 57.31%.

@@               Coverage Diff                @@
##           update-0.3.0     #139      +/-   ##
================================================
- Coverage         87.41%   87.30%   -0.11%     
================================================
  Files                44       44              
  Lines              2639     2695      +56     
  Branches            355      360       +5     
================================================
+ Hits               2307     2353      +46     
- Misses              310      324      +14     
+ Partials             22       18       -4
Impacted Files Coverage Δ
elastica/dissipation.py 95.45% <ø> (ø)
elastica/joint.py 22.10% <0.00%> (-1.53%) ⬇️
elastica/callback_functions.py 97.56% <100.00%> (+13.73%) ⬆️
elastica/external_forces.py 96.22% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7075496...735fe00. Read the comment docs.

armantekinalp
armantekinalp approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhosale2
bhosale2 approved these changes Jul 16, 2022
View reviewed changes
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 merged commit 09babf1 into GazzolaLab:update-0.3.0 Jul 16, 2022
@skim0119 skim0119 deleted the update_ci_sphinx branch July 16, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@bhosale2 bhosale2 bhosale2 approved these changes

Assignees

@skim0119 skim0119

Labels
documentation Improvements or additions to documentation update Update the codebase
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@skim0119 @codecov-commenter @bhosale2 @armantekinalp