Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FixedJoints: restoring spring-damped-torques, initial rotation offset #135

Merged
merged 40 commits into from
Jul 19, 2022
Merged

Update FixedJoints: restoring spring-damped-torques, initial rotation offset #135

merged 40 commits into from
Jul 19, 2022

Commits on Jul 14, 2022

  1. Fix GazzolaLab#131 for FixedJoints by applying restoring torques on r… 

    …otation errors using rotational spring-damper systems
    @mstoelzle
    mstoelzle committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    0ccba62 View commit details
    Browse the repository at this point in the history

  2. Use JointCasesCallback also for remaining joint cases examples

    @mstoelzle
    mstoelzle committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    e7d1b22 View commit details
    Browse the repository at this point in the history

  3. Formatting using black

    @mstoelzle
    mstoelzle committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    b72bdc9 View commit details
    Browse the repository at this point in the history

  4. Scipy as_rotvec has issue in documentation about degrees parameter

    @mstoelzle
    mstoelzle committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    a27ee99 View commit details
    Browse the repository at this point in the history

  5. Adjust test for FixedJoint

    @mstoelzle
    mstoelzle committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    6c8ac25 View commit details
    Browse the repository at this point in the history

  6. Fix direction of compensation damping torque for FixedJoint

    @mstoelzle
    mstoelzle committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    187bb09 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Improve plotting for fixed_joint_torsion example

    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    368be52 View commit details
    Browse the repository at this point in the history

  2. Enable the FixedJoint to automatically configure a static rotation of… 

    …fset
    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    2107805 View commit details
    Browse the repository at this point in the history

  3. Fix final time of fixed_joint_torsion example

    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    5ddeaa1 View commit details
    Browse the repository at this point in the history

  4. Fix test of FixedJoint 

    - remove static rotation from test
- Improve checking of nut damping
- Fix sign error for computing restoring rotational damping torque
    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    1b21120 View commit details
    Browse the repository at this point in the history

  5. Replace JointCasesCallback with MyCallback

    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    5b37950 View commit details
    Browse the repository at this point in the history

  6. Remove branching for self.nut > 0.0

    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    d8d7be8 View commit details
    Browse the repository at this point in the history

  7. Fix unclear docstrings

    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    00ecf2f View commit details
    Browse the repository at this point in the history

  8. Rename rot_vec in inertial frame to rot_vec_inertial_frame

    @mstoelzle
    mstoelzle committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    cfae6d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Rename static to rest in docstring 

    Co-authored-by: Yashraj Bhosale <[email protected]>
    @mstoelzle @bhosale2
    mstoelzle and bhosale2 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    b4ae266 View commit details
    Browse the repository at this point in the history

  2. rename error_rot to dev_rot 

    Co-authored-by: Yashraj Bhosale <[email protected]>
    @mstoelzle @bhosale2
    mstoelzle and bhosale2 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    e3792f7 View commit details
    Browse the repository at this point in the history

  3. Rename error_omega to dev_omega 

    Co-authored-by: Yashraj Bhosale <[email protected]>
    @mstoelzle @bhosale2
    mstoelzle and bhosale2 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    95f4f8b View commit details
    Browse the repository at this point in the history

  4. Finish renaming error_rot to dev_rot and error_omega to dev_omega

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    3b7a1fd View commit details
    Browse the repository at this point in the history

  5. Some more renaming of variables 

    - `use_static_rotation` --> `enforce_rest_joint_state`
- `self.static_rotation` --> `self.rest_rotation_matrix`
    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    9a5cf1c View commit details
    Browse the repository at this point in the history

  6. Make rest_rotation_matrix initialization parameter of FixedJoint class 

    We provide a function `get_relative_rotation_two_systems` to easily compute this rest rotation matrix
    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    cb84464 View commit details
    Browse the repository at this point in the history

  7. Fix utilization of diagnostic directors data in fixed_joint_torsion

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    63c8399 View commit details
    Browse the repository at this point in the history

  8. Remove initialization of rest_rotation_matrix during main loop

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    8fd8976 View commit details
    Browse the repository at this point in the history

  9. Update elastica/joint.py 

    Co-authored-by: Arman Tekinalp <[email protected]>
    @mstoelzle @armantekinalp
    mstoelzle and armantekinalp authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    c97c9b4 View commit details
    Browse the repository at this point in the history

  10. Update elastica/joint.py 

    Co-authored-by: Arman Tekinalp <[email protected]>
    @mstoelzle @armantekinalp
    mstoelzle and armantekinalp authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    dc59e29 View commit details
    Browse the repository at this point in the history

  11. Replace numpy default argument with None

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    91d1817 View commit details
    Browse the repository at this point in the history

  12. Fix sign error of dev_omega

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    7b351c5 View commit details
    Browse the repository at this point in the history

  13. Also rotate omega to inertial frame in test_fixedjoint

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    e334b09 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'bugfix/fixed-joint-torsional-torque' of https://github.… 

    …com/tud-cor-sr/PyElastica into bugfix/fixed-joint-torsional-torque
    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    08a34d8 View commit details
    Browse the repository at this point in the history

  15. Reformatting with black

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    9d48697 View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'upstream/update-0.3.0' into bugfix/fixe… 

    …d-joint-torsional-torque
    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    5608760 View commit details
    Browse the repository at this point in the history

  17. Remove joint_cases_callback

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    6d360f6 View commit details
    Browse the repository at this point in the history

  18. Fix missing transpose in get_relative_rotation_two_systems

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    d31173e View commit details
    Browse the repository at this point in the history

  19. Align rod2 in fixed_joint_torsion along (0,1,0), enabling example t… 

    …o use `rest_rotation_matrix`
    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    f157413 View commit details
    Browse the repository at this point in the history

  20. Add example to docstring of get_relative_rotation_two_systems 

    Co-authored-by: Seung Hyun Kim <[email protected]>
    @mstoelzle @skim0119
    mstoelzle and skim0119 authored Jul 16, 2022
    Configuration menu
    Copy the full SHA
    cf368be View commit details
    Browse the repository at this point in the history

  21. Finish examples of get_relative_rotation_two_systems

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    4868dc5 View commit details
    Browse the repository at this point in the history

  22. Some reformatting

    @mstoelzle
    mstoelzle committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    f36cf35 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. Update elastica/joint.py 

    Co-authored-by: Arman Tekinalp <[email protected]>
    @mstoelzle @armantekinalp
    mstoelzle and armantekinalp authored Jul 17, 2022
    Configuration menu
    Copy the full SHA
    9397d00 View commit details
    Browse the repository at this point in the history

  2. Replace scipy rotation vector with custom numba _inv_rotate

    @mstoelzle
    mstoelzle committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    035e0ed View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bugfix/fixed-joint-torsional-torque' of https://github.… 

    …com/tud-cor-sr/PyElastica into bugfix/fixed-joint-torsional-torque
    @mstoelzle
    mstoelzle committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    34c6b2b View commit details
    Browse the repository at this point in the history

  4. Test fixed joint for a variety of rest rotation matrices

    @mstoelzle
    mstoelzle committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    d84f5f1 View commit details
    Browse the repository at this point in the history