Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch @ember/render-modifiers #88

Closed
NullVoxPopuli opened this issue Oct 1, 2021 · 2 comments
Closed

Ditch @ember/render-modifiers #88

NullVoxPopuli opened this issue Oct 1, 2021 · 2 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

We should provide our own modifier implementation for now, because @ember/render-modifiers throws a deprecation in Ember 3.22+ and render-modifiers are anti-patternyish https://nullvoxpopuli.com/avoiding-lifecycle
NullVoxPopuli added a commit to NullVoxPopuli/ember-headlessui that referenced this issue Oct 3, 2021
@NullVoxPopuli
Ditch render-modifiers as a dependency and see what breaks / where it…
94f9bd0 
… is used

Begins GavinJoyce#88
@NullVoxPopuli NullVoxPopuli mentioned this issue Oct 3, 2021
Closed
@NullVoxPopuli
Copy link
Collaborator Author

Potentially, we could go this approach so that we are compatible with Ember 4 once the old modifier managers are removed: https://github.com/NullVoxPopuli/ember-popperjs/blob/main/addon/-private/-function-modifier.ts

NullVoxPopuli added a commit to NullVoxPopuli/ember-headlessui that referenced this issue Oct 3, 2021
@NullVoxPopuli
Ditch render-modifiers as a dependency and see what breaks / where it…
b4de5c9 
… is used

Begins GavinJoyce#88
@NullVoxPopuli NullVoxPopuli mentioned this issue Dec 6, 2021
Closed
@NullVoxPopuli
Copy link
Collaborator Author

Resolved in #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NullVoxPopuli