Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the initial addon #1

Closed
9 tasks done
GavinJoyce opened this issue Jun 7, 2019 · 1 comment · Fixed by #2
Closed
9 tasks done

Implement the initial addon #1

GavinJoyce opened this issue Jun 7, 2019 · 1 comment · Fixed by #2

Comments

@GavinJoyce
Copy link
Collaborator

GavinJoyce commented Jun 7, 2019

This addon should migrate component templates to be co-located as per emberjs/rfcs#481

We can likely leverage some of https://github.com/rwjblue/ember-module-migrator as it does similar things.

Initial todos:

  • Manually create some apps with non-colocated components (nested, template only etc.)
  • Create manual migration PRs (to learn what the codemod needs to do)
  • Decide on architecture of codemod
    • Do we need to modify any javascript? If not, the codemod will likely be much simpler
  • Implement MVP for Classic app (allowing a path to support "folder + index" style too) : Implement initial codemod #2
@GavinJoyce
Copy link
Collaborator Author

GavinJoyce commented Jul 19, 2019

Thinking about this a little more, I think this addon should focus on migrating a classic app only. We could create a separate codemod, at some point, to migrate from pods to a classic structure. That would mean that any future classic -> future codemods wouldn't have to concern themselves with the complexity of supporting pods

@GavinJoyce GavinJoyce changed the title Implement this addon Implement the initial addon Jul 22, 2019
rwjblue pushed a commit that referenced this issue Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant