Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dependency to require R-4.2 #16

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

ycl6
Copy link

@ycl6 ycl6 commented Sep 25, 2023

This PR change the required R version to 4.2 to run ichorCNA.

This is due to a bug in GenomeInfoDb to handle hg38 assembly (see #11). The fixed version (v1.34.8) is available in BioC 3.16 (R-4.2). Therefore in order for ichorCNA to work properly when genomeBuild = "hg38", it will also require to run under R-4.2.

I also updated the versions of the imported packages to the version most updated in R-4.2.

@ycl6
Copy link
Author

ycl6 commented Sep 27, 2023

I have updated the DESCRIPTION to add missing dependencies for data.table and plyr
Also the filterEmptyChr function is uncommented so that createPanelOfNormals can be used to create panel of normals.

@gavinha gavinha merged commit 1c8cd2c into GavinHaLab:master Oct 5, 2023
@istvankleijn istvankleijn mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants