Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): add Xonotic #4633

Merged
merged 49 commits into from
Aug 28, 2024
Merged

Conversation

Hornochs
Copy link
Contributor

@Hornochs Hornochs commented Aug 23, 2024

Description

Adding Xonotic as supportes Server

Fixes #3936

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@Hornochs
Copy link
Contributor Author

Any feedback if I need to do something? @dgibbs64 @glowacki-dev @intel44

@dgibbs64
Copy link
Member

I will take look and review it. Thanks

@dgibbs64 dgibbs64 changed the base branch from master to develop August 27, 2024 21:13
@dgibbs64 dgibbs64 added this to the v24.3.0 milestone Aug 28, 2024
@dgibbs64
Copy link
Member

Completed my review and contributions to get everything up to standard. Non Steam servers normally require some extra work. Thanks for your contirbution

@dgibbs64 dgibbs64 merged commit ce27b73 into GameServerManagers:develop Aug 28, 2024
3 checks passed
@Hornochs
Copy link
Contributor Author

Thank you very much for your time and effort completing this PR ❤️. I‘m happy that I was able to give a little start and make it possible for LinuxGSM to add this Arenashooter.

Can‘t wait to install it with LinuxGSM 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] Xonotic
2 participants