Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vhserver): enable crossplay support #4544

Merged
merged 5 commits into from
May 22, 2024

Conversation

glowacki-dev
Copy link
Contributor

@glowacki-dev glowacki-dev commented Mar 23, 2024

Description

Based on the following reddit thread https://www.reddit.com/r/valheim/comments/xshlyk/dedicated_server_on_linux_crossplay_switch_not/

Enabling crossplay on linux server required installing some additional dependencies. Out of the 3 mentioned there only libatomic1 and libpulse-dev seem to be required.
Once they have been installed and -crossplay flag is set the server succesfully registers with PlayFab and is visible in microsoft store version of the game.

I've only tested this setup on Ubuntu 22.04 and was able to see the server both in steam browser and in xbox pc version.

Server logs show the following PlayFab registration and join code assignment:

03/23/2024 21:35:49: Game server connected
03/23/2024 21:35:52: Joined PlayFab Party network with ID "<REDACTED>"
03/23/2024 21:35:53: Created PlayFab lobby with ID "<REDACTED>", ConnectionString "<REDACTED>" and owned by "<REDACTED>"
03/23/2024 21:35:53: Session "My Server" registered with join code 701230
03/23/2024 21:35:54: Retry join-code check 99
03/23/2024 21:35:56: Session "My Server" with join code 701230 and IP <REDACTED>:2456 is active with 0 player(s)

Fixes #4543

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added this to the v24.3.0 milestone May 22, 2024
@dgibbs64 dgibbs64 merged commit a2bea8d into GameServerManagers:develop May 22, 2024
3 checks passed
@irobot73
Copy link

CROSSPLAY still appears to be dorked.

Pulled the LATEST & had the server start-up. Getting the following every ~30-sec.

09/24/2024 13:05:02: Server 'Double-D's Valheim Server' begin PlayFab create and join network for server 
09/24/2024 13:05:32: PlayFab reconnect server 'Double-D's Valheim Server'

Ran the following via console (as I had [to do] prior to the recent push)

sudo apt update && sudo apt install -y libatomic1 libpulse0 libpulse-dev

Restart server & all seems to be working as expected again.

@dgibbs64
Copy link
Member

I think there might be a depdenceny check bug as LinuxGSM should be alerting if dependencies are missing and they are listed in the csv file

@irobot73
Copy link

irobot73 commented Sep 24, 2024

I think there might be a dependency check bug as LinuxGSM should be alerting if dependencies are missing and they are listed in the csv file

Funny (odd). I just ran UPDATE(-LGSM) via console & the LGSM request appeared to update/remove quite a few files...Again, this was post fresh pull ala (maybe some caching issue somewhere??):
docker-compose down && docker-compose pull && docker-compose up -d --build

I'm going to run through the whole process just to 2x check/try to reproduce

EDIT (15:09+):

Completely nuked the container/image from the system, ran the following to pull/build:

docker-compose down && docker-compose pull && docker-compose up -d --build

Server started but gave the same/prior 'reconnect' messages every ~30-sec.
UPDATE-LGSM did update.

linuxgsm@7116fba7cb72:/app$ ./*server update-lgsm
[  OK  ] Updating LinuxGSM vhserver: Selecting repo: GitHub
checking GitHub linuxgsm.sh...UPDATE
fetching GitHub linuxgsm.sh...OK
checking vhserver...UPDATE
backup vhserver...OK
backup location /app/lgsm/backup/script/vhserver-09_24_2024_06.bak
copying vhserver...OK
checking GitHub config _default.cfg...UPDATE
fetching GitHub _default.cfg...OK
checking GitHub module README.md...OK
checking GitHub module alert.sh...UPDATE
fetching GitHub alert.sh...OK
checking GitHub module alert_discord.sh...UPDATE
fetching GitHub alert_discord.sh...OK

Restarted container via DOCKER. UPDATE-LGSM showed all 'OK'. Still had the 'reconnect' messages (corrected via dependency install & restart).

So, yes, I'd say something missing in the start-up dependency check+.


EDIT: 10/01/24

Dropped & nuked the container. Pulled latest (same as above). Server came up & ran the following to check the dependencies:

sudo apt update && sudo apt install libatomic1 libpulse0 libpulse-dev

Everything up to date!! Cache issue?? Either way, CROSSPLAY doesn't need any work-around, so TY again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants