Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pwserver): fix updated start parameters #4516

Merged

Conversation

MicLieg
Copy link
Contributor

@MicLieg MicLieg commented Feb 28, 2024

Description

I've implemented the changes suggested by @Crimson-Decoded to support the changed start parameters for Palworld.

Fixes #4514

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@MicLieg MicLieg force-pushed the fix/4514-pwserver-config-update branch from 15ef58c to 0dba7d2 Compare February 28, 2024 23:36
@Dessa
Copy link
Contributor

Dessa commented Feb 29, 2024

as of 0.1.5.1 (roughly 3 hours ago) the rcon change no longer seems to be necessary, according to the patch notes

@PlayMTL
Copy link
Contributor

PlayMTL commented Mar 1, 2024

lgtm

@dgibbs64 dgibbs64 added this to the v24.2.0 milestone Mar 1, 2024
@dgibbs64 dgibbs64 merged commit c5ca762 into GameServerManagers:develop Mar 2, 2024
3 checks passed
dgibbs64 pushed a commit that referenced this pull request Mar 2, 2024
* fix(pw): fix updated  start parameters

* fix(pw): remove unneeded RCON parameters
dgibbs64 pushed a commit that referenced this pull request Mar 2, 2024
* fix(pw): fix updated  start parameters

* fix(pw): remove unneeded RCON parameters
@MicLieg MicLieg deleted the fix/4514-pwserver-config-update branch March 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants