Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arma3): rework parsing of config #3886

Merged

Conversation

Marcin648
Copy link
Contributor

@Marcin648 Marcin648 commented Jun 2, 2022

Description

Rework Arma3 server config parsing to use sed without grep.
Tested on Ubuntu Focal and CentOS 8.

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64
Copy link
Member

dgibbs64 commented Jun 2, 2022

Very nice. Ideally, I would like a standardised way of parsing info from various configs and have that data added to the top of the file or in the dev wiki

@dgibbs64 dgibbs64 added this to the v22.1.0 milestone Jun 2, 2022
@dgibbs64 dgibbs64 merged commit 74020fb into GameServerManagers:develop Jun 2, 2022
@Marcin648 Marcin648 deleted the arma3-config-parsing branch June 2, 2022 23:52
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants