Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add execution of check_ip before the config init #3289

Merged
merged 2 commits into from
Feb 21, 2021

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Feb 21, 2021

Description

Fix a regression with the new startparameter system

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added the type: bug Something isn't working label Feb 21, 2021
@h3o66 h3o66 added this to the v21.2.0 milestone Feb 21, 2021
@h3o66 h3o66 requested a review from dgibbs64 February 21, 2021 14:38
@dgibbs64 dgibbs64 merged commit 0ab5734 into GameServerManagers:develop Feb 21, 2021
@h3o66 h3o66 deleted the fix/startparameter-ip branch February 21, 2021 21:18
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants