Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(vhserver) Add support for changing savedir in valheim #3266

Merged
merged 1 commit into from
Feb 19, 2021
Merged

fix:(vhserver) Add support for changing savedir in valheim #3266

merged 1 commit into from
Feb 19, 2021

Conversation

Voziv
Copy link
Contributor

@Voziv Voziv commented Feb 17, 2021

Description

Adds a variable savedir with it set to the default location that valheim dedicated server currently uses. This is to avoid any breaking changes.

Fixes #3253

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64
Copy link
Member

dgibbs64 commented Feb 17, 2021

Thanks for the PR

I will be deciding if it should be in a hotfix or the next release

@dgibbs64 dgibbs64 linked an issue Feb 17, 2021 that may be closed by this pull request
@dgibbs64 dgibbs64 self-requested a review February 19, 2021 20:44
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this thank you 🚀 !

@dgibbs64 dgibbs64 added this to the v21.2.0 milestone Feb 19, 2021
@dgibbs64 dgibbs64 self-assigned this Feb 19, 2021
@dgibbs64 dgibbs64 changed the title fix: Add support for changing savedir in valheim fix:(vhserver) Add support for changing savedir in valheim Feb 19, 2021
@dgibbs64 dgibbs64 merged commit 9e30f4f into GameServerManagers:develop Feb 19, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] valheim startparameters missing -savedir config
2 participants