Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minecraft): fix java ram assignment #3147

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Dec 28, 2020

Description

Fixes the assignment of the java ram var

Fixes #2540

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added type: bug Something isn't working game: Minecraft labels Dec 28, 2020
@h3o66 h3o66 linked an issue Dec 28, 2020 that may be closed by this pull request
@h3o66 h3o66 requested a review from dgibbs64 December 28, 2020 20:42
@buer22
Copy link
Member

buer22 commented Dec 28, 2020

I can confirm this works.

image

Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy as confirmed working

@dgibbs64 dgibbs64 added this to the v21.1.0 milestone Dec 29, 2020
@dgibbs64 dgibbs64 merged commit 5d58dcf into GameServerManagers:develop Dec 29, 2020
@h3o66 h3o66 deleted the fix/mc-java-ram branch December 29, 2020 11:52
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
game: Minecraft type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minecraft javaram setting broken
3 participants