-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
During update, check against branch being public. #3130
During update, check against branch being public. #3130
Conversation
This change fixes the update command for those on public branches. Possibly needs testing and confirmation.
This needs to be merged in ASAP. It's breaking all of our servers with the recent CSGO update. The fix is working for me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the [ FAIL ] Updating arkserver: Checking remote build: SteamCMD
on Ubuntu 20.04.
I can confirm this is a problem for me too. (debian10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as intended
./rustserver update
[ OK ] Updating rustserver: Checking for update: SteamCMD
No update available
* Local build: 5984887
* Remote build: 5984887
* Branch: public
https://steamdb.info/app/258550/
For me on Debian 9 (Stretch) not work ./rustserver u [ FAIL ] Updating rustserver: Checking remote build: SteamCMD... |
Verify you updated/replaced the file on the server |
This seems to be the fix for me too on Ubuntu 18.04 for CS:GO, cheers. |
I confirm, it works for Rust Server change line 45 of home/ACCOUNT/lgsm/functions/update_steamcmd.sh to: |
Did someone test if this as well works with a branch name set ? |
I will get this into a hotfix. |
This change fixes the update command for those on public branches. add fix to core_dl.sh
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This change fixes the update command for those on public branches. Possibly needs testing and confirmation.
Fixes #3072
Fixes #3079
Fixes #3106
Fixes #3129
Fixes #3131
Type of change
Check if branch var is 'public' to use correct
remoteBuild
execution.Checklist
PR will not be merged until all steps are complete.
develop
branch as its base.