Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During update, check against branch being public. #3130

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

JoinedSenses
Copy link

@JoinedSenses JoinedSenses commented Dec 17, 2020

Description

This change fixes the update command for those on public branches. Possibly needs testing and confirmation.

Fixes #3072
Fixes #3079
Fixes #3106
Fixes #3129
Fixes #3131

Type of change

Check if branch var is 'public' to use correct remoteBuild execution.

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • [?] This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

This change fixes the update command for those on public branches. Possibly needs testing and confirmation.
@EnriqCG
Copy link

EnriqCG commented Dec 18, 2020

This needs to be merged in ASAP. It's breaking all of our servers with the recent CSGO update. The fix is working for me 👍

Copy link

@jamesonp jamesonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the [ FAIL ] Updating arkserver: Checking remote build: SteamCMD on Ubuntu 20.04.

@xSL0W
Copy link

xSL0W commented Dec 18, 2020

I can confirm this is a problem for me too. (debian10)

Copy link
Member

@Grimston Grimston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended

./rustserver update
[  OK  ] Updating rustserver: Checking for update: SteamCMD

No update available
* Local build: 5984887
* Remote build: 5984887
* Branch: public
https://steamdb.info/app/258550/

@carek5
Copy link

carek5 commented Dec 18, 2020

For me on Debian 9 (Stretch) not work ./rustserver u

[ FAIL ] Updating rustserver: Checking remote build: SteamCMD...

@JoinedSenses
Copy link
Author

For me on Debian 9 (Stretch) not work ./rustserver u

[ FAIL ] Updating rustserver: Checking remote build: SteamCMD...

Verify you updated/replaced the file on the server

@JamsRepos
Copy link

This seems to be the fix for me too on Ubuntu 18.04 for CS:GO, cheers.

@carek5
Copy link

carek5 commented Dec 18, 2020

I confirm, it works for Rust Server

change line 45 of home/ACCOUNT/lgsm/functions/update_steamcmd.sh to:
elif [ -n "${branch}" ]&&[ "${branch}" != "public" ]; then

@h3o66
Copy link
Member

h3o66 commented Dec 18, 2020

Did someone test if this as well works with a branch name set ?

@dgibbs64
Copy link
Member

I will get this into a hotfix.

@dgibbs64 dgibbs64 changed the base branch from master to hotfix/v20.6.2 December 18, 2020 21:59
@dgibbs64 dgibbs64 merged commit 3a583fa into GameServerManagers:hotfix/v20.6.2 Dec 18, 2020
dgibbs64 added a commit that referenced this pull request Dec 18, 2020
This change fixes the update command for those on public branches. 
add fix to core_dl.sh
@JoinedSenses JoinedSenses deleted the patch-1 branch December 19, 2020 03:01
@h3o66 h3o66 added this to the v20.6.2 milestone Dec 19, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
9 participants