Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new server): pvrserver #2384

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jun 9, 2019

Description

Please include a summary of the change and which issue is fixed.

Fixes #2382

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

@h3o66
Copy link
Member Author

h3o66 commented Jun 9, 2019

If someone can please feel free to test this :)

@dgibbs64 dgibbs64 requested a review from a team June 10, 2019 17:12
@dgibbs64 dgibbs64 added the type: game server request Request for a new server label Jun 10, 2019
@h3o66
Copy link
Member Author

h3o66 commented Jun 10, 2019

Note for the server:
2 ports are needed in standard it is port 7000 and 7200
port1: value
port2: value +200

@h3o66 h3o66 force-pushed the feature/pvrserver branch 2 times, most recently from 0089c70 to d22b121 Compare June 10, 2019 20:37
@GameServerManagers GameServerManagers deleted a comment Jun 10, 2019
@GameServerManagers GameServerManagers deleted a comment Jun 10, 2019
@h3o66
Copy link
Member Author

h3o66 commented Jun 10, 2019

Current issue of the Server:
Deletes the content of the Downloaded config after the first start ( Game.ini )
Asked on their discord if they know this issue.

Reference:
https://discordapp.com/channels/267301605882200065/267345481984638986/587743159191077080

Discord
Step up your game with a modern voice & text chat app. Crystal clear voice, multiple server and channel support, mobile apps, and more. Get your free server now!

@Frisasky
Copy link
Contributor

since this server does not supports running multi instances so i think port wont be big problem
beside as far as i know, no other servers utilizing port 7000 and 7200
we can just hard coded the port in config file maybe

@dgibbs64 dgibbs64 closed this Jun 15, 2019
@dgibbs64 dgibbs64 reopened this Jun 15, 2019
@dgibbs64 dgibbs64 changed the title [WIP] feat(pvrserver): add new server [WIP] feat(new server): pvrserver Jun 17, 2019
@h3o66
Copy link
Member Author

h3o66 commented Jun 20, 2019

since this server does not supports running multi instances so i think port wont be big problem
beside as far as i know, no other servers utilizing port 7000 and 7200
we can just hard coded the port in config file maybe

i dont think multi instances are not possible, but someone who can test this would be good.
The -Port Parameter allows to change the port

So i am running 2 instances on the same Server
udp 0 0 0.0.0.0:7000 0.0.0.0:* 1002 1521889 19552/./PavlovServe
udp 0 0 0.0.0.0:7001 0.0.0.0:* 1003 1515026 15972/./PavlovServe
udp 0 0 0.0.0.0:7200 0.0.0.0:* 1002 1521883 19552/./PavlovServe
udp 0 0 0.0.0.0:7201 0.0.0.0:* 1003 1516587 15972/./PavlovServe

if this works is another thing, about the wiped config i have no answer for this yet.....

I am not sure if i should remove now the WIP from this because it works except that the game config is wiped by the game at the first start.

@Frisasky
Copy link
Contributor

Frisasky commented Jul 3, 2019

i think we can craft a fix script, start and stop the server once, then download the config file again

@YannKr
Copy link
Contributor

YannKr commented Aug 7, 2019

Howdy, is there anything I can do to help unblock this PR?

@Frisasky
Copy link
Contributor

did a quick testing, it still getting overwritten

@Frisasky Frisasky changed the title [WIP] feat(new server): pvrserver feat(new server): pvrserver Sep 14, 2019
@Frisasky
Copy link
Contributor

Frisasky commented Sep 14, 2019

created a rather crude fix, feel free to test it

@Frisasky Frisasky changed the title feat(new server): pvrserver [WIP] feat(new server): pvrserver Sep 14, 2019
@Frisasky
Copy link
Contributor

Frisasky commented Sep 14, 2019

well found out even with this fix it still overwritten the config file as long as you start the server
@h3o66 can you asking about the config file problem on their discord again? including this new finding

@dgibbs64 dgibbs64 closed this Nov 15, 2019
@dgibbs64 dgibbs64 reopened this Nov 15, 2019
@pull-assistant
Copy link

pull-assistant bot commented Dec 6, 2019

Score: 0.93

Best reviewed: commit by commit


Optimal code review plan (7 warnings)

feat(pvrserver): add new server

lgsm/functions/info_parms.sh 71% changes removed in Merge branch 'develo...

     Merge branch 'develop' into feature/pvrserver

Merge branch 'develop' into feature/pvrserver

lgsm/functions/command_stop.sh 43% changes removed in Merge branch 'develo...

Merge branch 'develop' into feature/pvrserver

...ctions/install_server_files.sh 46% changes removed in Merge branch 'develo...

lgsm/functions/fix_unt.sh 50% changes removed in Merge branch 'develo...

tests/tests_fctrserver.sh 50% changes removed in Merge branch 'develo...

Merge branch 'develop' into feature/pvrserver

...gsm/functions/command_start.sh 67% changes removed in Merge branch 'develo...

...gsm/functions/command_debug.sh 50% changes removed in Merge branch 'develo...

...sm/functions/command_fastdl.sh 67% changes removed in Merge branch 'develo...

lgsm/functions/info_distro.sh 50% changes removed in Merge branch 'develo...

     Update core_functions.sh

     Create fix_pvr.sh

     Update fix.sh

Merge branch 'develop' into feature/pvrserver

...g-lgsm/rustserver/_default.cfg 41% changes removed in Merge branch 'develo...

...ctions/install_server_files.sh 42% changes removed in Merge branch 'develo...

lgsm/functions/mods_core.sh 57% changes removed in Merge branch 'develo...

.../functions/command_validate.sh 67% changes removed in Merge branch 'develo...

...m/functions/update_steamcmd.sh 50% changes removed in Merge branch 'develo...

...ig-lgsm/ts3server/_default.cfg 41% changes removed in Merge branch 'develo...

...ons/command_ts3_server_pass.sh 50% changes removed in Merge branch 'develo...

     Update fix.sh

     Delete fix_pvr.sh

     Update core_functions.sh

Merge branch 'develop' into feature/pvrserver

...ithub/pull_request_template.md 50% changes removed in Merge branch 'develo...

.travis.yml 67% changes removed in Merge branch 'develo...

...ctions/install_server_files.sh 96% changes removed in Merge branch 'develo...

lgsm/functions/check_logs.sh 50% changes removed in Merge branch 'develo...

...ons/command_dev_detect_deps.sh 67% changes removed in Merge branch 'develo...

.../functions/update_minecraft.sh 50% changes removed in Merge branch 'develo...

lgsm/functions/check_status.sh 50% changes removed in Merge branch 'develo...

...m/functions/update_steamcmd.sh 50% changes removed in Merge branch 'develo...

     Update info_parms.sh

     Update _default.cfg

Merge branch 'develop' into feature/pvrserver

...g-lgsm/sdtdserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ctions/install_server_files.sh 71% changes removed in Merge branch 'develo...

     Merge branch 'develop' into feature/pvrserver

     no query available

     removed queryport

Powered by Pull Assistant. Last update 7893e55 ... 0f72994. Read the comment docs.

@h3o66
Copy link
Member Author

h3o66 commented Apr 15, 2020

image
conversation on the discord about the config wiping issue.
If nobody minds i will close this

@Frisasky
Copy link
Contributor

yeah i agree, if they dont think its a problem at all, we shouldnt care about this game either

@h3o66 h3o66 linked an issue Oct 28, 2020 that may be closed by this pull request
4 tasks
@h3o66
Copy link
Member Author

h3o66 commented Oct 28, 2020

So the server is now rebased to the latest lgsm release

@h3o66
Copy link
Member Author

h3o66 commented Oct 29, 2020

@h3o66
Copy link
Member Author

h3o66 commented Oct 29, 2020

To consider to revisit the Server port config:
http://wiki.pavlov-vr.com/index.php?title=Dedicated_server#Advanced_Server_Administration

Dedicated server - Pavlov VR Wiki

so I revisted a bit the port config according to the docs.

Updated the default port to 7777 and updated the additional port shifting for the server for the details.
(Another port that is needed for the gameserver to be opened)

@h3o66 h3o66 changed the title [WIP] feat(new server): pvrserver feat(new server): pvrserver Oct 29, 2020
@h3o66
Copy link
Member Author

h3o66 commented Nov 2, 2020

The inital problem might be solved with the config update via this PR:
GameServerManagers/Game-Server-Configs#105

@h3o66
Copy link
Member Author

h3o66 commented Nov 4, 2020

if someone want to test the current branch from my side for LGSM here is how:

Either create a seperate user for the server or a seperate folder for the server and start there with these commands (Do NOT use the root user !)

wget -O linuxgsm.sh https://linuxgsm.sh && chmod +x linuxgsm.sh

sed -i 's/^githubuser=.*/githubuser="h3o66"/g' linuxgsm.sh
sed -i 's/^githubbranch=.*/githubbranch="feature\/pvrserver"/g' linuxgsm.sh

./linuxgsm.sh pvrserver
./pvrserver auto-install

The Server can be stoppen and started with
./pvrserver start

Stop
./pvrserver stop

The intial server config file is in
serverfiles/Pavlov/Saved/Config/LinuxServer/Game.ini

Please give a update if you have tested it and it works now

@silelmot
Copy link

tested h3o66s added pavlov-server on 2 pcs and 3 installations and it worked out of the box on arch and debian.

@h3o66
Copy link
Member Author

h3o66 commented Nov 18, 2020

tested h3o66s added pavlov-server on 2 pcs and 3 installations and it worked out of the box on arch and debian.

Thanks for testing

@h3o66 h3o66 added this to the v20.6.0 milestone Nov 18, 2020
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested on Ubuntu and works

@dgibbs64 dgibbs64 merged commit afe2b70 into GameServerManagers:develop Nov 18, 2020
@h3o66 h3o66 deleted the feature/pvrserver branch November 18, 2020 22:51
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: game server request Request for a new server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] Pavlov VR Dedicated Server
5 participants