Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/api ref site #9

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Doc/api ref site #9

merged 2 commits into from
Oct 24, 2023

Conversation

sandytang886
Copy link
Member

please help me review branch doc/api-ref-site

@sandytang886 sandytang886 added the feature For those who propose to add new feature or modify existing features label Oct 22, 2023
@sandytang886 sandytang886 added this to the in-progress milestone Oct 22, 2023
@sandytang886 sandytang886 self-assigned this Oct 22, 2023
Copy link
Collaborator

@metalalive metalalive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the 3 API endpoints in this doc site look good to me.
If other reviewers don't respond yet for too long (like one or two days), please tag them at here or message them for this PR.

@KalpasWang
Copy link
Collaborator

looks good! I think it's ready to be merged to main branch.

@metalalive
Copy link
Collaborator

metalalive commented Oct 24, 2023

@KalpasWang

you didn't approve the PR, do you know how to do this ?
Go to the tab Files Changed, it lists all files changed in the PR.
You click the checkbox along with the text viewed, for each file after reading it,
think about whether the change / the code makes sense (<-- important, code review should be a way of communication, since this team embrace async communication)
then finally click approve button with your comment.

@KalpasWang
Copy link
Collaborator

@KalpasWang

you didn't approve the PR, do you know how to do this ? Go to the tab Files Changed, it lists all files changed in the PR. You click the checkbox along with the text viewed, for each file after reading it, think about whether the change / the code makes sense (<-- important, code review should be a way of communication, since this team embrace async communication) then finally click approve button with your comment.

sorry, I've never reviewed other people's PR.
I approved it, is there anything I'm still missing?

@wingtkw wingtkw merged commit 8c12619 into main Oct 24, 2023
3 checks passed
@sandytang886 sandytang886 removed this from the in-progress milestone Oct 25, 2023
@metalalive metalalive deleted the doc/api-ref-site branch October 30, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature For those who propose to add new feature or modify existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants