Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: apply FlatBuffers payload to socket.io server on game config events #57

Merged
merged 2 commits into from
Feb 7, 2024
Merged

feature: apply FlatBuffers payload to socket.io server on game config events #57

merged 2 commits into from
Feb 7, 2024

Conversation

metalalive
Copy link
Collaborator

@metalalive metalalive commented Feb 6, 2024 •
edited
Loading

This is the 4th (final) portion of the TODO list in #37

This PR includes following socket.io events that transmit payload in FlatBuffers format :

  • switch character
  • set difficulty level

Note :

  • Other events reflecting change of the game state can encode / decode payload in the same way for enhancing performance.
  • If frontend webapp requires to encode / decode chat message using FlatBuffers , please read the documentation above.
  • I will merge the PR if nobody can help me review the code or give any feedback by 11:59 AM (GMT+8) 7th Feb. 2024.

c.c. @KalpasWang , @wingtkw

@metalalive
[#37] feature: apply binary payload format to socket.io server
7a07047 
- integrate with FlatBuffers
- binary payload generaated on switch-character event

Signed-off-by: T.H. <[email protected]>
@metalalive
[#37] feature: apply binary payload format to socket.io server
bf61893 
- integrate with FlatBuffers
- binary payload generated on difficulty-config event

Signed-off-by: T.H. <[email protected]>
@metalalive metalalive added feature For those who propose to add new feature or modify existing features backend dev For back-end development related to this codebase labels Feb 6, 2024
@metalalive metalalive requested a review from wingtkw February 6, 2024 14:33
@metalalive metalalive self-assigned this Feb 6, 2024
metalalive
metalalive commented Feb 7, 2024
View reviewed changes
Copy link
Collaborator Author

@metalalive metalalive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK , I'll merge the PR,
@wingtkw , you can still give feedback, ask any question related to the code in this PR afterward, by leaving comment in a new GitHUb Issue.

Thanks

@metalalive metalalive merged commit aa9a5e2 into main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingtkw wingtkw Awaiting requested review from wingtkw

Assignees

@metalalive metalalive

Labels
backend dev For back-end development related to this codebase feature For those who propose to add new feature or modify existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metalalive