Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit events on difficulty and character update #55

Merged

Conversation

metalalive
Copy link
Collaborator

This is the 3rd portion of the TODO list in #37

  • http server emits corresponding event on completing the operations to socket.io server
  • socket.io server simply forwards the game-state messages to corresponding players of a given game

@wingtkw ,
according to the previous discussion ,
if you happen to see this PR please help to review my code by the end of 1st. Feb 2024 ,
after that I will merge the PR first ,
you are still welcome to leave comment at here,
or create another issue / discussion thread for any question about my code at here ,
thanks.

- http server emits corresponding event on completing the operations to
  socket.io server
- socket.io server simply forwards the game-state messages to
  corresponding players of a given game

Signed-off-by: T.H. <[email protected]>
@metalalive metalalive added feature For those who propose to add new feature or modify existing features backend dev For back-end development related to this codebase labels Feb 1, 2024
@metalalive metalalive requested a review from wingtkw February 1, 2024 05:22
@metalalive metalalive self-assigned this Feb 1, 2024
Copy link
Collaborator Author

@metalalive metalalive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@metalalive metalalive merged commit 2994db9 into main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dev For back-end development related to this codebase feature For those who propose to add new feature or modify existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant