Restrict players to the game room in socketio server, by http server emits event on creating game #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… game - socketio server collects the events, to know all the ongoing games - http server maintains a shared socketio client sending all relavant events - rename `AbstractRepository` to `AbstractGameRepository` - TODO, implement room repository for real-time communication Signed-off-by: T.H. <[email protected]>
- implement (currently in-memory) room repository , so the socketio server knows all the ongoing games - check from the room repository when player attempts to initialize (or de-initialize) real-time communication (RTC) through the socketio event `INIT` (or `DEINIT`) - add new member to `GameFuncCodes`, for RTC endpoints (e.g. currently `socketio`) Signed-off-by: T.H. <[email protected]>
metalalive
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements second part of the TODO list in #37 :
socketioserver collects the events, to know all the ongoing gamessocketioclient sending all relevant eventsAbstractRepositorytoAbstractGameRepositorysocketioserver knows all the ongoing gamesINIT(orDEINIT)GameFuncCodes, for RTC endpoints (e.g. currentlysocketio)@wingtkw , according to the previous discussion , if you happen to see this PR please help to review my code by the end of 25th. Jan 2024 , after that I will merge the PR first , you are still welcome to leave comment at here, or create another issue / discussion thread for any question about my code at here , thanks.
C.C. @KalpasWang , @liamlin1102
Feel free ask questions about the
socket.ioserver-side implementation