:feature create user #155
Merged
:feature create user #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
force-pushed
the
feature/create-user
branch
from
4bc3a7c to
f053ff1
Compare
Closed
Wally5077
requested changes
Aug 21, 2023
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/UserControllerTest.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| fun givenUserNotLoginAtProxyService_whenUserCreateAnUser_thenUserShouldBeCreatedFail() { |
Comment on lines
101
to
119
| .contentType(MediaType.APPLICATION_JSON) | ||
| .contentType(APPLICATION_JSON) | ||
| .content(updateUserRequest.toJson()) |
Comment on lines
157
to
158
| .contentType(APPLICATION_JSON) | ||
| .content(CreateUserRequest(email).toJson()) |
Comment on lines
173
to
175
| post("/users") | ||
| .contentType(APPLICATION_JSON) | ||
| .content(CreateUserRequest(email).toJson()) |
Comment on lines
164
to
168
| userRepository.findByEmail(email) | ||
| .also { assertThat(it).isNotNull } | ||
| .also { assertThat(it!!.nickname).isNotNull() } | ||
| .also { assertThat(it!!.identities).isNotNull() } | ||
| .also { assertThat(it!!.email).isEqualTo(email) } |
Comment on lines
181
to
182
| userRepository.findByEmail(email) | ||
| .also { assertThat(it).isNull() } |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue
POST /usersAPI #152