實作取得房間資訊 #124
Merged
實作取得房間資訊 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankvicky
requested changes
Jul 13, 2023
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/GetRoomUsecase.kt
Outdated
Show resolved
Hide resolved
| with(request) { | ||
| val room = findRoomById(Room.Id(roomId))!! | ||
| room.validatePlayerInRoom(Player.Id(userId)) | ||
| room.also { presenter.present(it) } |
There was a problem hiding this comment.
這邊可以直接 presenter.present(room)
Wally5077
requested changes
Jul 13, 2023
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/GetRoomUsecase.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/GetRoomUsecase.kt
Outdated
Show resolved
Hide resolved
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/presenter/GetRoomPresenter.kt
Outdated
Show resolved
Hide resolved
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/presenter/GetRoomPresenter.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
ted791029
force-pushed
the
feature/get-room
branch
2 times, most recently
from
236c8c0 to
588ac54
Compare
frankvicky
requested changes
Jul 20, 2023
|
|
||
| private fun Room.validatePlayerInRoom(playerId: Player.Id) { | ||
| if (!hasPlayer(playerId)) { | ||
| throw PlatformException("Player(" + playerId!!.value + ") is not in the room(" + roomId!!.value + ").") |
| val host = createUser("2", "[email protected]", "winner1122").toRoomPlayer() | ||
| givenHostAndPlayersJoinedTheRoom(host) | ||
| .whenUserGetTheRoom(userA) | ||
| .thenShouldFail("Player(" + userA.id!!.value + ") is not in the room(" + testRoom.roomId!!.value + ").") |
There was a problem hiding this comment.
ditto
使用 String interpolate
ted791029
force-pushed
the
feature/get-room
branch
from
588ac54 to
2503358
Compare
Wally5077
requested changes
Jul 20, 2023
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/GetRoomUsecase.kt
Outdated
Show resolved
Hide resolved
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/GetRoomUsecase.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt
Outdated
Show resolved
Hide resolved
ted791029
force-pushed
the
feature/get-room
branch
from
2503358 to
54999f7
Compare
ted791029
force-pushed
the
feature/get-room
branch
from
54999f7 to
e4f960a
Compare
frankvicky
approved these changes
Jul 25, 2023
依據jwt subject is user identity修正 根據第三次 code review 修正 根據第二次 code review 修正 根據第一次 code review 修正 實作取得房間資訊
ted791029
force-pushed
the
feature/get-room
branch
from
e4f960a to
5d31a08
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue
GET /rooms/{roomId}取得房間資訊 #64