Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 實作一個人同時只能加入一個房間。 #123

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

frankvicky
Copy link
Collaborator

Why need this change? / Root cause:

  • 一個人同時只能加入一個房間。

Changes made:

  • JoinRoomUsecase

Test Scope / Change impact:

  • RoomControllerTest

Issue

@frankvicky frankvicky requested a review from Wally5077 July 12, 2023 15:09
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@frankvicky frankvicky force-pushed the feature/join-one-room-at-same-time branch from a1c72d9 to b548dc8 Compare July 12, 2023 16:59
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankvicky frankvicky merged commit 2fa2855 into main Jul 12, 2023
@frankvicky frankvicky deleted the feature/join-one-room-at-same-time branch July 12, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

一人只能進入一間房
2 participants