feat: allow memo in paycode

GaloyMoney · Oct 31, 2023 · ca27ba5 · ca27ba5
1 parent a174d5a
commit ca27ba5
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/__tests__/payment-request/payment-request-creation-data.spec.ts b/__tests__/payment-request/payment-request-creation-data.spec.ts
@@ -65,7 +65,7 @@ describe("create payment request creation data", () => {
     expect(prcd.canUsePaycode).toBe(true)
     expect(prcd.username).toBe("test-username")
     expect(prcd.canSetAmount).toBe(true)
-    expect(prcd.canSetMemo).toBe(false)
+    expect(prcd.canSetMemo).toBe(true)
     expect(prcd.canSetReceivingWalletDescriptor).toBe(false)
     expect(prcd.receivingWalletDescriptor).toBe(btcWalletDescriptor)
   })

diff --git a/app/screens/receive-bitcoin-screen/payment/payment-request-creation-data.ts b/app/screens/receive-bitcoin-screen/payment/payment-request-creation-data.ts
@@ -36,7 +36,7 @@ export const createPaymentRequestCreationData = <T extends WalletCurrency>(
   // Permissions for the specified type
   const permissions = {
     canSetReceivingWalletDescriptor: false,
-    canSetMemo: false,
+    canSetMemo: true,
     canSetAmount: true,
   }
   if (type === Invoice.Lightning || type === Invoice.OnChain) {

diff --git a/app/screens/receive-bitcoin-screen/payment/payment-request.ts b/app/screens/receive-bitcoin-screen/payment/payment-request.ts
@@ -209,23 +209,23 @@ export const createPaymentRequest = (
 
       // Paycode
     } else if (pr.type === Invoice.PayCode && pr.username) {
-      const queryStringForAmount =
-        pr.unitOfAccountAmount === undefined || pr.unitOfAccountAmount.amount === 0
-          ? ""
-          : `amount=${pr.unitOfAccountAmount?.amount}&currency=${pr.unitOfAccountAmount?.currencyCode}`
+      const baseLnurl = `${pr.posUrl}/.well-known/lnurlp/${pr.username}`
+      const url = new URL(baseLnurl)
+
+      if (pr.unitOfAccountAmount !== undefined && pr.unitOfAccountAmount.amount !== 0) {
+        url.searchParams.append("amount", pr.unitOfAccountAmount.amount.toString())
+        url.searchParams.append("currency", pr.unitOfAccountAmount.currencyCode)
+      }
+
+      if (pr.memo !== "") {
+        url.searchParams.append("comment", pr.memo)
+      }
 
       const lnurl: string = await new Promise((resolve) => {
         resolve(
           bech32.encode(
             "lnurl",
-            bech32.toWords(
-              Buffer.from(
-                `${pr.posUrl}/.well-known/lnurlp/${pr.username}${
-                  queryStringForAmount ? `?${queryStringForAmount}` : ""
-                }`,
-                "utf8",
-              ),
-            ),
+            bech32.toWords(Buffer.from(url.toString(), "utf8")),
             1500,
           ),
         )