SyGuS #226
Merged
SyGuS #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RyanGlScott do you know why the CI fails? |
Merged
RyanGlScott
reviewed
Dec 13, 2022
There was a problem hiding this comment.
do you know why the CI fails?
I think this is because the CI is using an especially old version of Nix. I've submitted #227 with a fix.
chameco
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Since this is a large change, it would be nice to document some things in the PR description / eventual squashed commit message. In particular:
- broadly, what has changed that could affect existing codepaths (such as using Z3 normally through What4 from SAW) in case something breaks elsewhere - I suspect this isn't too much, but e.g. things like the
IsSymFntypeclass change - what new features were introduced, and what is the interface to those features
I think overall this looks good to merge, pending some additional documentation. Thanks for the tests for the new functionality. It might also be nice to use some of our existing proofs to make sure that existing functionality doesn't break - in the absence of Fryingpan, CI passing on a draft SAW PR that points to this branch would be reassuring.
andreistefanescu
force-pushed
the
sygus
branch
from
de9ceff to
56e57e0
Compare
RyanGlScott
added a commit
to GaloisInc/language-sally
that referenced
this pull request
Mar 10, 2023
GaloisInc/what4#226 adds some additional methods to `SMTWriter` that `language-sally` must implement.
RyanGlScott
added a commit
to GaloisInc/language-sally
that referenced
this pull request
Mar 13, 2023
GaloisInc/what4#226 adds some additional methods to `SMTWriter` that `language-sally` must implement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Syntax Guided Synthesis (SyGuS) and Constrained Horn Clauses (CHC).