Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a feature to ask for abducts #213

Merged
merged 41 commits into from
Sep 1, 2022
Merged

Adding a feature to ask for abducts #213

merged 41 commits into from
Sep 1, 2022

Conversation

arjunvish
Copy link
Collaborator

When the SMT solver disproves g (finds ~g to be satisfiable), we can ask for abduct a that entail g, that is a ^ ~g is satisfiable. This feature is available with cvc5.

cabal.project Outdated Show resolved Hide resolved
what4/src/What4/Protocol/Online.hs Outdated Show resolved Hide resolved
what4/src/What4/Solver/CVC5.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/README.md Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/what4.cabal Outdated Show resolved Hide resolved
what4/what4.cabal Outdated Show resolved Hide resolved
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get back to this.

what4/what4.cabal Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/SMTWriter.hs Outdated Show resolved Hide resolved
.github/workflows/gen_matrix.pl Outdated Show resolved Hide resolved
what4/src/What4/Protocol/Online.hs Outdated Show resolved Hide resolved
what4/src/What4/Protocol/Online.hs Outdated Show resolved Hide resolved
@arjunvish
Copy link
Collaborator Author

@arjunvish arjunvish closed this Aug 29, 2022
@arjunvish arjunvish reopened this Aug 29, 2022
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test case! I'm quite happy with how it looks, modulo some minor suggestions.

what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
what4/test/Abduct.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @arjunvish. Thanks!

@arjunvish arjunvish merged commit 6f5e0fe into master Sep 1, 2022
@arjunvish arjunvish deleted the get-abduct branch September 1, 2022 16:06
RyanGlScott added a commit to GaloisInc/language-sally that referenced this pull request Oct 13, 2022
This bumps the `what4` submodule to bring in the changes from
GaloisInc/what4#213.  This requires implementing some new methods that were
added to the `SMTWriter` class, which proves straightforward.
RyanGlScott added a commit to GaloisInc/language-sally that referenced this pull request Dec 2, 2022
This bumps the `what4` submodule to bring in the changes from
GaloisInc/what4#213.  This requires implementing some new methods that were
added to the `SMTWriter` class, which proves straightforward.
RyanGlScott added a commit to GaloisInc/ambient-verifier that referenced this pull request Mar 1, 2023
This patch:

* Bumps the `crucible` and `what` submodules to bring in the changes from
  GaloisInc/crucible#1037 and
  GaloisInc/what4#213, which add support for CVC5 in
  the respective libraries.
* Adds `CVC5` support in the verifier.
* Updates the CI and Docker setups to ensure that CVC5 is included in both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants