-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a feature to ask for abducts #213
Conversation
…taken from the front-end
…ot compatible. We need a better solution at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to get back to this.
|
Co-authored-by: Ryan Scott <[email protected]>
Co-authored-by: Ryan Scott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a test case! I'm quite happy with how it looks, modulo some minor suggestions.
Co-authored-by: Ryan Scott <[email protected]>
Co-authored-by: Ryan Scott <[email protected]>
Co-authored-by: Ryan Scott <[email protected]>
Merge branch 'get-abduct' of https://github.com/GaloisInc/what4 into get-abduct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @arjunvish. Thanks!
This bumps the `what4` submodule to bring in the changes from GaloisInc/what4#213. This requires implementing some new methods that were added to the `SMTWriter` class, which proves straightforward.
This bumps the `what4` submodule to bring in the changes from GaloisInc/what4#213. This requires implementing some new methods that were added to the `SMTWriter` class, which proves straightforward.
This patch: * Bumps the `crucible` and `what` submodules to bring in the changes from GaloisInc/crucible#1037 and GaloisInc/what4#213, which add support for CVC5 in the respective libraries. * Adds `CVC5` support in the verifier. * Updates the CI and Docker setups to ensure that CVC5 is included in both.
When the SMT solver disproves
g
(finds~g
to be satisfiable), we can ask for abducta
that entailg
, that isa ^ ~g
is satisfiable. This feature is available with cvc5.