Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types-requests to toml file. #1644

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add types-requests to toml file. #1644

merged 1 commit into from
Mar 19, 2024
+30 −10

Conversation

mccleeary-galois
Copy link
Contributor

@mccleeary-galois mccleeary-galois commented Mar 19, 2024 •
edited
Loading

@mccleeary-galois mccleeary-galois self-assigned this Mar 19, 2024
@mccleeary-galois mccleeary-galois marked this pull request as ready for review March 19, 2024 19:30
RyanGlScott
RyanGlScott approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! One small suggestion, but otherwise this LGTM.

cryptol-remote-api/python/pyproject.toml Show resolved Hide resolved
@mccleeary-galois mccleeary-galois changed the title Add type-requests to toml file. Add types-requests to toml file. Mar 19, 2024
@mccleeary-galois mccleeary-galois linked an issue Mar 19, 2024 that may be closed by this pull request
mypy --install-types not freezing dependencies #1643
Closed
@mccleeary-galois mccleeary-galois merged commit c62c653 into master Mar 19, 2024
45 checks passed
@mccleeary-galois mccleeary-galois deleted the rem/iss-1643 branch March 19, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees

@mccleeary-galois mccleeary-galois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mypy --install-types not freezing dependencies
2 participants
@mccleeary-galois @RyanGlScott