Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version command to cryptol-remote-api #1547

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Add version command to cryptol-remote-api #1547

merged 7 commits into from
Jul 10, 2023

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Jul 6, 2023

This PR adds a version command to the cryptol-remote-api and its Python interface. For example:

>>> connection.version()
CryptolVersionInfo(
  rpc_version='3.0.1.99',
  version='3.0.0.99',
  commit_hash='8c811b06a435f5009e8b75b36ecc8fc220e4d6bd',
  commit_branch='version-python-cmd',
  commit_dirty=True,
  ffi_enabled=True)

See the docs for the command in Version.hs or the docstring of CryptolVersionInfo in the Python API for descriptions of these fields.

Resolves #1544

@m-yac m-yac temporarily deployed to github-pages July 6, 2023 20:50 — with GitHub Actions Inactive
@m-yac m-yac temporarily deployed to github-pages July 6, 2023 20:57 — with GitHub Actions Inactive
RyanGlScott
RyanGlScott reviewed Jul 6, 2023
View reviewed changes
src/Cryptol/Version.hs Outdated Show resolved Hide resolved
cryptol-remote-api/cryptol-remote-api.cabal Show resolved Hide resolved
cryptol-remote-api/python/pyproject.toml Show resolved Hide resolved
@m-yac m-yac temporarily deployed to github-pages July 10, 2023 17:29 — with GitHub Actions Inactive
@m-yac m-yac temporarily deployed to github-pages July 10, 2023 17:47 — with GitHub Actions Inactive
@m-yac m-yac merged commit 2064a38 into master Jul 10, 2023
43 checks passed
@m-yac m-yac deleted the version-python-cmd branch July 10, 2023 19:49
@WeeknightMVP WeeknightMVP mentioned this pull request Jul 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

@weaversa weaversa Awaiting requested review from weaversa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cryptol-remote-api version info
2 participants
@m-yac @RyanGlScott