Mir.Intrinsics: Don't pass SimState when SymGlobalState/IntrinsicTypes will suffice
#1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s will suffice This makes it possible to call into the `crucible-mir` memory model without needing access to a full-blown `SimState`, which is sometimes not available in SAW contexts. Fixes #1105.
…ality Much of the memory model–related functionality in `Mir.Intrinsics` is defined in terms of `FancyMuxTree`s, which are somewhat clunky to manipulate outside of `crucible-mir`. `Mir.Intrinsics` does provide some wrapper functions to encapsulate the `FancyMuxTree` manipulation, but these typically live in the `OverrideSim` monad, which is more specific than we want for SAW's needs. This patch adds `IO` wrappers alongside the `OverrideSim` wrappers to make it more straightforward to use them in SAW.
29 tasks
RyanGlScott
added a commit
that referenced
this pull request
Aug 31, 2023
A follow-up to #1105/#1106. I found myself needing `subanyMirRefIO`, `subfieldMirRefIO`, and `subjustMirRefIO` in an upcoming SAW patch, but to avoid having to make a bunch of little patches each time I need more things from the `crucible-mir` memory model, I opted to define `*IO` functions for each memory model operation that performs side effects. After this patch, it should be straightforward to call anything in the `crucible-mir` memory model without too much trouble.
RyanGlScott
added a commit
that referenced
this pull request
Aug 31, 2023
…1107) A follow-up to #1105/#1106. I found myself needing `subanyMirRefIO`, `subfieldMirRefIO`, and `subjustMirRefIO` in an upcoming SAW patch, but to avoid having to make a bunch of little patches each time I need more things from the `crucible-mir` memory model, I opted to define `*IO` functions for each memory model operation that performs side effects. After this patch, it should be straightforward to call anything in the `crucible-mir` memory model without too much trouble.
RyanGlScott
added a commit
that referenced
this pull request
Feb 1, 2024
RyanGlScott
added a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit e1dec5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to call into the
crucible-mirmemory model without needing access to a full-blownSimState, which is sometimes not available in SAW contexts.Fixes #1105.