This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Cross-browser clear input field #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -562,8 +562,7 @@ def write_textfield(id_or_elem, new_text, check=True, clear=True): | |||
| # clear field with send_keys(), don't use clear() (see | |||
There was a problem hiding this comment.
Do you want to remove the comment about using send_keys() and not clear()?
|
Næs! |
txels
force-pushed
the
master-clear-input
branch
from
1c0aed1 to
6447602
Compare
txels
force-pushed
the
master-clear-input
branch
from
6447602 to
c06e7a3
Compare
| textfield.send_keys(keys.Keys.DELETE) | ||
| if textfield.get_attribute('value') != '': | ||
| # for when send_keys does not work, e.g. PhantomJS | ||
| textfield.clear() |
There was a problem hiding this comment.
@arnlaugsson I've gone for a cowardly non-committal approach.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely to work well on PhantomJS, Chrome, Firefox... Linux, OSX... tested locally on OSX with all three browsers.