Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Common.hs to other-modules in benchmarks #166

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Add Common.hs to other-modules in benchmarks #166

merged 1 commit into from
Apr 21, 2016

Conversation

RyanGlScott
Copy link
Contributor

Currently, pipes' benchmarks fail to build on Hackage since Common isn't listed as other-modules of the benchmarks, which means cabal sdist doesn't package up Common.hs with the tarball.

See also commercialhaskell/stackage#1372

@Gabriella439
Copy link
Owner

Oh, thanks for fixing that! I apologize for the breakage

@Gabriella439 Gabriella439 merged commit 4da11fe into Gabriella439:master Apr 21, 2016
@Gabriella439
Copy link
Owner

I can upload this as soon as you want if there are no other impending changes

@RyanGlScott
Copy link
Contributor Author

Sounds good! That's the only thing I needed to fix.

@Gabriella439
Copy link
Owner

Alright, this is up on Hackage as pipes-4.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants