Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfaults on windows starting ~2022/01/30 #25

Closed
tlambert03 opened this issue Jan 31, 2022 · 2 comments
Closed

Segfaults on windows starting ~2022/01/30 #25

tlambert03 opened this issue Jan 31, 2022 · 2 comments

Comments

@tlambert03
Copy link

tlambert03 commented Jan 31, 2022

Yesterday, we started seeing all of our windows tests fail immediately with: failed with exit code 3221225477
(see for example: https://github.com/napari/napari/actions/runs/1768885019)

It appears that manually performing the os check, and not using this action on windows fixes it:

      - name: Test with tox
        uses: GabrielBB/xvfb-action@v1
        if: runner.os == 'Linux'
        with:
          run: tox

see napari/napari#4031

Any thoughts on what might have changed in the last couple days that would break the "no-op" functionality on windows for this action?

@tlambert03 tlambert03 changed the title Segfaults on windows starting ~2022/01/29 Segfaults on windows starting ~2022/01/30 Jan 31, 2022
@tlambert03
Copy link
Author

@GabrielBB, any thoughts here? I'm more than happy to help debug. we've got a number of repos using this action, all of which are failing to pass on windows at the moment... so I've got some motivation to work on it :)
would you suspect an update to the @actions/exec pin would do anything?

@tlambert03
Copy link
Author

tlambert03 commented Feb 3, 2022

i was able to narrow it down to a python environment related issue. Something has changed, but I'm not sure where.
Whereas this used to work to test something (for example, with pytest-qt driving a headless Qt test):

      # using actions/setup-python above...
      - uses: GabrielBB/xvfb-action@v1
        with:
          run: pytest

in the last few days, it now requires:

      - uses: GabrielBB/xvfb-action@v1
        with:
          run: python -m pytest

I think it's safe to say it's unrelated to xvfb-action, so will close this.

psobolewskiPhD added a commit to psobolewskiPhD/napari-aicsimageio that referenced this issue Feb 19, 2022
evamaxfield pushed a commit to AllenCellModeling/napari-aicsimageio that referenced this issue Feb 20, 2022
* try `python -m` before pytest

GabrielBB/xvfb-action#25 (comment)

* typo

* same fix to build-main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant