feat(target): Add target local #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, it is not necessary to publish to the Chrome store. But you want the zipped extension.
|
This is great, please merge it @GabrielDuarteM |
|
Hey @pohy 👋 Thank you for the PR! I think this behaviour used to be possible before when you declared the plugin list. They used to allow you to opt-in/out of specific steps when declaring the plugin list (example here), but I can't find that anymore on the docs, so I guess at some point it was removed. In any case, the code looks good to me. Not sure why the build pipeline is not being reported here, but I ran them locally and they passed, so I'll just merge it 👍 |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for merging! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds another flag to the
targetoption. Namely,target: 'local'.When set, checking for environment variables is skipped in the
verifyConditionsstep. As well as uploading the bundle to the Chrome store, during thepublishstep.Why
It is sometimes desirable to skip publishing to Chrome store, but still update the version in manifest.json and obtain the zipped bundle.
I.e. for publishing on the GitLab/Github releases page only.
Type of change
Release for testing
https://www.npmjs.com/package/@pohy/semantic-release-chrome
Checklist
npm run cito be sure).