Fix calculation of final image height/width in multi-resolution layouts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverages Monitor.__repr__() in monitor_parser
|
Seems to be working fine, that's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
@GabMus I found the cause! The resolving of
final_image_widthwas previously ruling out monitor entries if they didn't have the largestoffset_x, however for my 4K monitor width needs to be considered before taking amax. Applying changes forfinal_image_heightas well, this appears to be a complete fix. Note that I have wiped out logic related tozero_offset_width, which I believe is unnecessary, but please verify this on your end.Fully tested in my GNOME 3 desktop environment.