Feat: #24 상태 추가 모달 UI 작성 및 Form Validation 추가 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seok93
added
🧱 Component
⚙️ Config
Yoonyesol
reviewed
Jun 24, 2024
| import Validator from '@utils/Validator'; | ||
| import { deepFreeze } from '@utils/deepFreeze'; | ||
|
|
||
| export const STATUS_VALIDATION_RULES = deepFreeze({ |
There was a problem hiding this comment.
freeze는 사용해봤는데 deepFreeze는 처음 들어봐서 찾아봤더니, 우석님이 직접 utils에 만들어두신 거였네요...! 우석님의 내공을 다시 한번 느끼면서... 많이 배워갑니다!
Yoonyesol
approved these changes
Jun 24, 2024
|
예솔님 리뷰 감사합니다. 해결하고 보면 별 일이 아닌데, 고민할 땐 어렵게 다가오네요 ㅎㅎ.. 아직 추가적으로 구현해야할 기능들이 남아있지만, 1차적으로 UI 작업이 끝난 것 같습니다. 색상 추가에 대하여 한가지 고민이 있는데, 오늘 있을 회의에서 대화해보면 좋을 것 같아요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#24 상태 추가 모달 UI 작성
What does this PR do?
Other information
View