-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: #241 프로젝트 수정 UI 구현 #242
Conversation
Walkthrough이 변경 사항은 Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🧹 Outside diff range and nitpick comments (1)
src/components/modal/project/UpdateModalProject.tsx (1)
39-39
:loading
변수명 개선 제안
useAxios
에서 반환된loading
변수가 컴포넌트 내 다른 로딩 상태 변수들과 혼동될 수 있습니다. 가독성을 높이기 위해isUserListLoading
과 같이 보다 명확한 이름으로 변경하는 것을 권장합니다.수정을 위한 코드 변경 제안:
-const { loading, data: userList = [], clearData, fetchData } = useAxios(findUserByTeam); +const { loading: isUserListLoading, data: userList = [], clearData, fetchData } = useAxios(findUserByTeam);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- src/components/modal/project/UpdateModalProject.tsx (1 hunks)
- src/hooks/query/useProjectQuery.ts (2 hunks)
🔇 Additional comments (1)
src/hooks/query/useProjectQuery.ts (1)
34-36
: 성능 최적화가 잘 되어있습니다.useMemo를 사용하여 프로젝트 검색을 최적화한 것이 좋습니다. 특히 프로젝트 목록이 큰 경우 성능상 이점이 있을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정UI 구현 고생 많으셨습니다! 점점 완성돼가는 게 보이네요👍👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작업 내용 확인했습니다! 고생하셨어요~
PR Type
What kind of change does this PR introduce?
Related Issues
What does this PR do?
Other information
프로젝트 이름 , 설명 , 기간 UI
프로젝트 팀원 UI
프로젝트 기간 시작일 종료일 가져오는 모습