Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: #241 프로젝트 수정 UI 구현 #242

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

ice-bear98
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • [UI] CSS 등 사용자 UI 디자인 추가/삭제/변경 했어요.

Related Issues

What does this PR do?

  • 프로젝트 수정 UI 구현
  • 특정 프로젝트 목록 데이터 가져오는 커스텀 훅 작성

Other information

프로젝트 이름 , 설명 , 기간 UI
스크린샷 2024-10-24 203632

프로젝트 팀원 UI
스크린샷 2024-10-24 203650

프로젝트 기간 시작일 종료일 가져오는 모습
스크린샷 2024-10-24 203706

@ice-bear98 ice-bear98 added the 🎨 UI 사용자 UI를 추가/삭제/변경 했어요 label Oct 24, 2024
@ice-bear98 ice-bear98 self-assigned this Oct 24, 2024
Copy link

coderabbitai bot commented Oct 24, 2024

Walkthrough

이 변경 사항은 UpdateModalProject 컴포넌트의 구조와 기능을 크게 수정하여 React Hook Form을 사용하여 폼 상태 및 유효성을 관리하도록 업데이트했습니다. 새로운 입력 컴포넌트들이 추가되어 프로젝트 업데이트를 위한 기능이 강화되었으며, 폼 제출 및 데이터 로딩 상태를 처리하는 로직이 개선되었습니다. 또한, 프로젝트 정보를 가져오는 로직이 추가되어 사용자 경험이 향상되었습니다.

Changes

파일 경로 변경 요약
src/components/modal/project/UpdateModalProject.tsx ModalProjectForm을 React Hook Form을 사용하는 새로운 폼 구조로 변경, 여러 새로운 입력 컴포넌트 추가, 폼 제출 로직 수정, 데이터 로딩 상태 처리 추가.
src/hooks/query/useProjectQuery.ts useReadProjectDetail 함수 추가, 특정 프로젝트의 상세 정보를 가져오는 기능 구현.

Assessment against linked issues

Objective Addressed Explanation
프로젝트 수정 UI (241)
기존 프로젝트 정보 가져오기 (241)

Possibly related PRs

Suggested labels

🌟 Feature

Suggested reviewers

  • Seok93
  • Yoonyesol

🐰 변화의 바람이 불어오네,
프로젝트 업데이트가 새롭게 태어나네.
폼이 간편해지고, 사용자도 웃음 짓고,
모두 함께 즐거운 업데이트를 하네!
🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Outside diff range and nitpick comments (1)
src/components/modal/project/UpdateModalProject.tsx (1)

39-39: loading 변수명 개선 제안

useAxios에서 반환된 loading 변수가 컴포넌트 내 다른 로딩 상태 변수들과 혼동될 수 있습니다. 가독성을 높이기 위해 isUserListLoading과 같이 보다 명확한 이름으로 변경하는 것을 권장합니다.

수정을 위한 코드 변경 제안:

-const { loading, data: userList = [], clearData, fetchData } = useAxios(findUserByTeam);
+const { loading: isUserListLoading, data: userList = [], clearData, fetchData } = useAxios(findUserByTeam);
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 486a3d8 and 4463a4b.

📒 Files selected for processing (2)
  • src/components/modal/project/UpdateModalProject.tsx (1 hunks)
  • src/hooks/query/useProjectQuery.ts (2 hunks)
🔇 Additional comments (1)
src/hooks/query/useProjectQuery.ts (1)

34-36: 성능 최적화가 잘 되어있습니다.

useMemo를 사용하여 프로젝트 검색을 최적화한 것이 좋습니다. 특히 프로젝트 목록이 큰 경우 성능상 이점이 있을 것 같습니다.

@GU-99 GU-99 deleted a comment from coderabbitai bot Oct 24, 2024
Yoonyesol
Yoonyesol previously approved these changes Oct 24, 2024
Copy link
Contributor

@Yoonyesol Yoonyesol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정UI 구현 고생 많으셨습니다! 점점 완성돼가는 게 보이네요👍👍

Copy link
Contributor

@Seok93 Seok93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업 내용 확인했습니다! 고생하셨어요~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 UI 사용자 UI를 추가/삭제/변경 했어요
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로젝트 수정 데이터 가져오기 및 UI
3 participants