Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: #16 공용 Header 컴포넌트 UI 작성 #19

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Feat: #16 공용 Header 컴포넌트 UI 작성 #19

merged 3 commits into from
Jun 19, 2024

Conversation

Seok93
Copy link
Contributor

@Seok93 Seok93 commented Jun 18, 2024 •
edited by yachimiya
Loading

PR Type

What kind of change does this PR introduce?

  • [Feat] 새로운 기능을 추가했어요.
  • [Config] 환경설정을 변경했어요.
  • [Asset] 이미지 파일을 추가했어요.

Related Issues

#16 공용 Header 컴포넌트 작성

What does this PR do?

  • React icons 라이브러리 추가
  • logo 이미지 추가
  • 공용 Header UI 설정
  • 기본 레이아웃(Default Layout)에 Header 컴포넌트 추가

Other information

  1. React Router Docs - NavLink: children prop

@Seok93 Seok93 added 🖼 Asset 이미지 파일 추가했어요 🧱 Component 🌟 Feature 새로운 기능 개발했어요 🎨 UI 사용자 UI를 추가/삭제/변경 했어요 labels Jun 18, 2024
@Seok93 Seok93 requested review from Yoonyesol and kimpearl3599 June 18, 2024 14:36
@Seok93 Seok93 self-assigned this Jun 18, 2024
@Seok93 Seok93 added the ⚙️ Config 환경 설정 세팅했어요 label Jun 18, 2024
@Seok93 Seok93 linked an issue Jun 18, 2024 that may be closed by this pull request
공용 Header 컴포넌트 UI 작성 #16
Closed
2 tasks
@Seok93 Seok93 removed the 🎨 UI 사용자 UI를 추가/삭제/변경 했어요 label Jun 18, 2024
@Seok93 Seok93 marked this pull request as draft June 18, 2024 14:50
@kimpearl3599 kimpearl3599 marked this pull request as ready for review June 19, 2024 03:40
@kimpearl3599
Copy link

좋습니다 우석님!! >_<

@Seok93
Copy link
Contributor Author

Seok93 commented Jun 19, 2024

감사합니다! 그런데 기존에 정했던 디자인 크기랑 조금 다르게 설정한 부분이 있어요.
오늘 회의 시간에 대화해보고 싶은 부분입니다 🥲

@Seok93 Seok93 added 🎨 UI 사용자 UI를 추가/삭제/변경 했어요 and removed 🌟 Feature 새로운 기능 개발했어요 labels Jun 19, 2024
@Seok93
Copy link
Contributor Author

Seok93 commented Jun 19, 2024

회의 결과 새롭게 적용한 디자인 크기를 그대로 적용하기로 했으니, 그대로 merge 하겠습니다!

@Seok93 Seok93 merged commit 384035a into develop Jun 19, 2024
@Seok93 Seok93 changed the title Feat: #16 공용 Header 컴포넌트 UI 작성 UI: #16 공용 Header 컴포넌트 UI 작성 Jun 19, 2024
@Seok93 Seok93 deleted the feature/ui-header branch June 19, 2024 14:25
@Seok93 Seok93 changed the title UI: #16 공용 Header 컴포넌트 UI 작성 Feat: #16 공용 Header 컴포넌트 UI 작성 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimpearl3599 kimpearl3599 kimpearl3599 approved these changes

@Yoonyesol Yoonyesol Awaiting requested review from Yoonyesol

Assignees

@Seok93 Seok93

Labels
🖼 Asset 이미지 파일 추가했어요 ⚙️ Config 환경 설정 세팅했어요 🎨 UI 사용자 UI를 추가/삭제/변경 했어요
Projects
None yet
Milestone
Sprint 1: 프로젝트 개발 1-2주차
Development

Successfully merging this pull request may close these issues.

공용 Header 컴포넌트 UI 작성
2 participants
@Seok93 @kimpearl3599