Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: #128 유저 정보 값 수정 #129

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

Yoonyesol
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • [Etc] 변수명 및 타입명 수정했어요.

Related Issues

#128

What does this PR do?

  • 프로필 이미지 변수 변경: profileImageUrl -> profileImageName
  • 유저 조회 데이터에 userId, provider 추가
  • mock 데이터 및 타입명 변경
  • 속성 초기값을 ERD 명세에 맞게 수정

Other information

유저 정보 관련 변경 사항을 처리했습니다.

@Yoonyesol Yoonyesol added the 🗃️ Chore 그외 자잘한 수정 및 설정 label Sep 13, 2024
@Yoonyesol Yoonyesol self-assigned this Sep 13, 2024
@Yoonyesol Yoonyesol linked an issue Sep 13, 2024 that may be closed by this pull request
3 tasks
Copy link

coderabbitai bot commented Sep 13, 2024

Walkthrough

이 변경 사항은 사용자 프로필 이미지 데이터를 처리하는 방식에 대한 전반적인 수정으로, profileImageUrl 속성이 profileImageName으로 변경되었으며, 이와 관련된 타입 정의와 상태 관리가 업데이트되었습니다. 이로 인해 여러 컴포넌트와 서비스에서 프로필 이미지에 대한 처리 방식이 일관되게 조정되었습니다.

Changes

파일 경로 변경 요약
src/components/user/auth-form/ProfileImageContainer.tsx imageUrl 속성을 string에서 `string
src/mocks/mockData.ts USER_INFO_DUMMYUSER_DUMMY에서 profileImageUrlprofileImageName으로 변경하고, 주석 처리된 provideruserId 속성을 활성화.
src/pages/setting/UserSettingPage.tsx 상태 초기화 및 제출 로직에서 profileImageUrlprofileImageName으로 변경.
src/pages/user/SignUpPage.tsx 기본값을 null로 변경하고, 제출 함수에서 profileImageUrlprofileImageName으로 변경. 이미지 업로드 과정에서 File 객체 생성 시 일관성 유지.
src/services/authService.ts API 응답 타입을 EditUserInfoForm에서 User로 변경, getUserInfo 함수의 반환 타입 수정.
src/stores/useStore.ts userInfo 상태와 관련된 타입을 EditUserInfoForm에서 User로 변경하고, 새로운 속성 추가 및 기존 속성 수정.
src/types/UserType.tsx profileImageUrl 속성을 profileImageName으로 변경하고, 타입을 `string

Possibly related PRs

Suggested labels

🌟 Feature

Poem

🐰 변화의 바람이 불어와,
프로필 이미지 이름이 새롭게 태어나,
이제는 더 유연하게, 더 자유롭게,
사용자 정보가 빛을 발하네.
함께 나아가자, 모두 손잡고,
새로운 길로, 뛰어가자! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@Seok93 Seok93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경하신 내용 확인했습니다! 고생하셨어요😊

@Yoonyesol
Copy link
Contributor Author

@Seok93 리뷰 감사합니다! 후속 작업을 위해 빠른 머지하도록 하겠습니다!😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ Chore 그외 자잘한 수정 및 설정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

유저 정보 값 수정
2 participants