Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aspects to Warp Theory entities #38

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add aspects to Warp Theory entities #38

merged 1 commit into from
Apr 24, 2024

Conversation

D-Cysteine
Copy link

No description provided.

@D-Cysteine D-Cysteine requested a review from a team April 23, 2024 23:58
@Dream-Master
Copy link
Member

Are this not controlled via Thaumcraft Mob Aspects mod ? We have a warp Theory config but only passive creeper is listed
WarpTheory.zip

@D-Cysteine
Copy link
Author

Are this not controlled via Thaumcraft Mob Aspects mod ? We have a warp Theory config but only passive creeper is listed WarpTheory.zip

Huh, thanks, I didn't know about that mod. It does look like most of the configs for mods don't actually have any aspects listed though, including Warp Theory, like you said:

I feel like it probably makes sense to have that mod handle mobs from mods that aren't aware of / don't depend on Thaumcraft, but for mods that do, like Warp Theory, it might be better to have the mod itself handle registering aspects. That way we can keep the aspect definitions in the same repo as the actual entity, and update them in the same PR.

@Dream-Master
Copy link
Member

ok sure i just want to let you know.

@Alastors
Copy link

Yeah it'd be better to handle warp theory mobs in warp theory

@Dream-Master Dream-Master merged commit 1cdcc8d into master Apr 24, 2024
1 check passed
@Dream-Master Dream-Master deleted the entity-aspects branch April 24, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants