Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production modifier to apiary hud, add magic apiary to forestry handler #16

Merged
merged 9 commits into from
Sep 16, 2023

Conversation

hacatu
Copy link

@hacatu hacatu commented Aug 27, 2023

Apiary, bee house, alveary, and magic apiary will now include Effective production: b^0.52 * %s in their waila hud, giving a quick overview of how much effect the current production modifier is actually having. I also added this functionality to the industrial apiary but that handles its own waila hud, it doesn't go through the plugins mod.

spotlessApply and updateDependencies changed a lot of unrelated files so let me know if I need to redo this PR

@hacatu
Copy link
Author

hacatu commented Aug 27, 2023

Example tooltip in my testing world

@hacatu
Copy link
Author

hacatu commented Aug 27, 2023

The effective production reported for alvearies with electrical stimulators seems to be incorrect, which is really weird because it does seem to take into account frame housings. My first guess was it's because extrabees replaces the alveary tile entity but then it wouldn't change when I added frame housings. So unfortunately I'll have to look into that

@Dream-Master Dream-Master requested review from a team August 27, 2023 18:44
@hacatu
Copy link
Author

hacatu commented Aug 29, 2023

Fixed - it was just a simple issue of me accidentally doing some calculations clientside instead of serverside due to not fully understanding waila.

I also moved the "Effective Production" section to be after the drone section, so it doesn't split apart the queen and drone sections in the hud.

@kuba6000 kuba6000 self-requested a review September 14, 2023 07:51
@Dream-Master Dream-Master merged commit 2b9fdea into GTNewHorizons:master Sep 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants