Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IStructureElementChain returning an invalid Iterable #33

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Nov 9, 2024

You shouldn't concat null iterables as that will just cause the following whenever you try to iterate over it.

[STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:787]: java.lang.NullPointerException: Cannot invoke "java.lang.Iterable.iterator()" because "from" is null
[STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:787]: 	at System//com.google.common.collect.Iterables$3.transform(Iterables.java:512)
[STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:787]: 	at System//com.google.common.collect.Iterables$3.transform(Iterables.java:509)
[STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:787]: 	at System//com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
[STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:787]: 	at System//com.google.common.collect.Iterators$5.hasNext(Iterators.java:543)

@Lyfts Lyfts requested review from Glease and a team November 9, 2024 14:28
@Dream-Master Dream-Master merged commit 9b96560 into master Nov 9, 2024
1 check passed
@Dream-Master Dream-Master deleted the fix-iterable branch November 9, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants