Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported Storage Downgrade #5

Merged
merged 6 commits into from
Apr 9, 2021
Merged

Backported Storage Downgrade #5

merged 6 commits into from
Apr 9, 2021

Conversation

johnch18
Copy link

@johnch18 johnch18 commented Apr 3, 2021

I backported this from the 1.12 version of the mod.
It sets the base storage of a drawer to 1 stack, useful for creating inventories with a specific number of stacks.
e.g. A drawer with a downgrade and two emerald upgrades would have the normal number of stacks.

@mitchej123 mitchej123 requested a review from a team April 6, 2021 01:02
Copy link

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks fine. I'm not seeing an icon for the downgrade, I'd like to see that added, and some screenshots with evidence everything is working as expected.

@johnch18
Copy link
Author

johnch18 commented Apr 8, 2021

There we go. Had some issues with IntelliJ that I had to pin down.
image

@Dream-Master Dream-Master merged commit 74c980b into GTNewHorizons:1.7.10 Apr 9, 2021
@Prometheus0000
Copy link
Member

@johnch18 You added the recipe for default, but not for GTNH, so there is no recipe. See https://github.com/GTNewHorizons/StorageDrawers/pull/3/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants