Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChromatiCraft support, TC magic forest bigger #6

Closed
wants to merge 11 commits into from

Conversation

Dream-Master
Copy link
Member

re-open this pr

#5

@Dream-Master
Copy link
Member Author

@KuroPeach i just reopen the pr .

@KuroPeach
Copy link

I used dapi to generate two pictures. This is the comparison of the size of the magic forest after the rwg change. They use the same seeds. The bright green is the magic forest, and the purple is the place of corruption.

before change
-3, 4  (10001x10001;  R=10 b-px, G=-1-false )

after change
4, -1  (10001x10001;  R=10 b-px, G=-1-false )

@Dream-Master
Copy link
Member Author

@KuroPeach did you test in a GTNH full pack ? (2.3.0)

@Dream-Master
Copy link
Member Author

now the forrest are very huge

@KuroPeach
Copy link

I can add bop, the last test only has rwg biome and tc biome, so it is very big

@Dream-Master
Copy link
Member Author

run it in a gtnh 2.3.0 instance

@KuroPeach
Copy link

In the case of the full package test, my notebook does not start fast enough. If bop is involved, the test results are not much different from the full package. :)
before change
304, -4  (10001x10001;  R=10 b-px, G=-1-false )
after change It seems that only the upper left is the magic forest, there are too many bop biomes
298, -2  (10001x10001;  R=10 b-px, G=-1-false )

@Dream-Master
Copy link
Member Author

yea but we dont use bop worldgen. We use rwg put bop content to rwg world gen

@KuroPeach
Copy link

KuroPeach commented Mar 19, 2023

Yes, this test also uses the rwg generator,Because bop's generator is not a regular polygon, only rwg will generate such a pattern :)

@Dream-Master
Copy link
Member Author

so what color the magical forest has ?

@KuroPeach
Copy link

still is bright green
!legend

@Dream-Master
Copy link
Member Author

ok need to check ingame later

@Alastors
Copy link

I’m all for it, certain parts of thaumcraft are hidden in the forest and they’re borderline impossible to find, and even when you do they’re only like a chunk total size so effectively useless as currently is.

And I mean it shouldn’t have too much of an effect on existing worlds, I mean it’ll probably cause some sort of jagged chunk borders between the old chunks and new chunks, but honestly that’s not enough of a reason to not do it.

@Dream-Master
Copy link
Member Author

@KuroPeach sorry this take some time. We are willing to test this pr in gtnh can you add this change to a config so we can change values there ? Thanks

Copy link

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be behind a config. It should default to off for existing worlds, but being on for new worlds is fine
I don't want to introduce jagged borders to people that have an existing world unless they opt into it

Other than that seems fine.

@KuroPeach
Copy link

@KuroPeach sorry this take some time. We are willing to test this pr in gtnh can you add this change to a config so we can change values there ? Thanks

Sorry, I can't add a configuration file to it. I don't know how to code, I just make the existing modifications, and the original author didn't provide a configuration file to modify the parameters.

@Dream-Master
Copy link
Member Author

Where is the original author so I can contact him or her @KuroPeach ?

@KuroPeach
Copy link

https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1281910-teds-world-gen-mods-realistic-world-gen-alpha-1-3
Unable to contact, he or she appears to have been out of the community for 8 years

@Dream-Master
Copy link
Member Author

in this case i see no chance for the pr to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants