-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChromatiCraft support, TC magic forest bigger #6
Conversation
@KuroPeach i just reopen the pr . |
@KuroPeach did you test in a GTNH full pack ? (2.3.0) |
now the forrest are very huge |
I can add bop, the last test only has rwg biome and tc biome, so it is very big |
run it in a gtnh 2.3.0 instance |
yea but we dont use bop worldgen. We use rwg put bop content to rwg world gen |
Yes, this test also uses the rwg generator,Because bop's generator is not a regular polygon, only rwg will generate such a pattern :) |
so what color the magical forest has ? |
ok need to check ingame later |
I’m all for it, certain parts of thaumcraft are hidden in the forest and they’re borderline impossible to find, and even when you do they’re only like a chunk total size so effectively useless as currently is. And I mean it shouldn’t have too much of an effect on existing worlds, I mean it’ll probably cause some sort of jagged chunk borders between the old chunks and new chunks, but honestly that’s not enough of a reason to not do it. |
@KuroPeach sorry this take some time. We are willing to test this pr in gtnh can you add this change to a config so we can change values there ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be behind a config. It should default to off for existing worlds, but being on for new worlds is fine
I don't want to introduce jagged borders to people that have an existing world unless they opt into it
Other than that seems fine.
Sorry, I can't add a configuration file to it. I don't know how to code, I just make the existing modifications, and the original author didn't provide a configuration file to modify the parameters. |
Where is the original author so I can contact him or her @KuroPeach ? |
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1281910-teds-world-gen-mods-realistic-world-gen-alpha-1-3 |
in this case i see no chance for the pr to be added. |
re-open this pr
#5